Add cast feature new#3
Open
mahdishahbazi3653 wants to merge 21 commits intomainfrom
Open
Conversation
* Send video default subtitle back throw eventSink in Android * add subtitle event type to video_player interface * Convert event subtitle from eventSink to subtitle VideoEvent in Android * add subtitle to video player value and fill in case of receiving subtitle event * select default subtitle from available subtitles * add getEmbeddedSubtitles to interface * call getEmbeddedSubtitles in Android platform channel * add texture id to getEmbeddedSubtitle * handle getting subtitle on Android Native * add setEmbeddedSubtitles to interface * call setEmbeddedSubtitles platform method on Native Android * handle setSubtitle on Andorid Native * handle get subtitle on iOS * handle setEmbeddedSubtitle on iOS * stream subtitle using video controller caption * add documentations * add unit test for get and set subtitle on Android * add unit test for get and set subtitle on iOS * show caption on all position is embedded subtitle selected * add embeddedSubtitleSelected to interface * update documentations based on PR Co-authored-by: Mahdi Shahbazi <mahdishahbazi3653@yahoo.com>
# Conflicts: # packages/video_player/video_player/lib/video_player.dart # packages/video_player/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/Messages.java # packages/video_player/video_player_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java # packages/video_player/video_player_android/lib/src/android_video_player.dart # packages/video_player/video_player_android/lib/src/messages.g.dart # packages/video_player/video_player_android/pigeons/messages.dart # packages/video_player/video_player_android/test/android_video_player_test.dart # packages/video_player/video_player_android/test/test_api.dart # packages/video_player/video_player_avfoundation/ios/Classes/FLTVideoPlayerPlugin.m # packages/video_player/video_player_avfoundation/ios/Classes/messages.g.h # packages/video_player/video_player_avfoundation/ios/Classes/messages.g.m # packages/video_player/video_player_avfoundation/lib/src/avfoundation_video_player.dart # packages/video_player/video_player_avfoundation/lib/src/messages.g.dart # packages/video_player/video_player_avfoundation/pigeons/messages.dart # packages/video_player/video_player_avfoundation/test/avfoundation_video_player_test.dart # packages/video_player/video_player_avfoundation/test/test_api.dart # packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
* add enter pip method to video player controller * handle enter picture in picture on iOS native * handle enter picture in picture in Android native * update video player controller isPictureInPictureEnabled from native android * send state update from iOS to Flutter * fix merge conflict issues * add documentation and clean code * add unit tests * check error on calling enter picture in picture * fix ios crash on press back in pip * add setStartPictureInPictureAutomatically to video player for iOS specific --------- Co-authored-by: Mahdi Shahbazi <mahdishahbazi3653@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.