feat(api-client): P001 - Increase CustomApplicationSettings content limit validation#1328
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(api-client): P001 - Increase CustomApplicationSettings content limit validation#1328yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…gs content Update DeclarativeCustomApplicationSetting model to include maxLength: 250000 validation for the content field, matching the OpenAPI spec change from gdc-nas commit bee16eb300b19dd96bd59ee9e0325c2101c8207c. This ensures the SDK properly validates content size limits for custom application settings, which was increased from 15000 to 250000 characters to support larger LDM layouts. Related: STL-2278, P001 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
|
Workflow run -> I don't think it is relevant :D I need to finetune my prompt for analysis |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add maxLength: 250000 validation to DeclarativeCustomApplicationSetting content field.
Jira ticket creation skipped - sandbox under maintenance at time of PR creation.
Problem: P001 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22069292236
Changes
Updated the DeclarativeCustomApplicationSetting model to include maxLength: 250000 validation in the validations dict for the content field. This matches the OpenAPI spec change from gdc-nas commit bee16eb300b19dd96bd59ee9e0325c2101c8207c.
Context
In gdc-nas, the CustomApplicationSettings content field maxLength was increased from 15000 to 250000 characters to support larger LDM layouts (fixes STL-2278). The OpenAPI spec was updated to include this validation, but the SDK model was missing the validation enforcement.
Related