Skip to content

Fix: Copy Pull Button when tags are undefined#22136

Merged
Vad1mo merged 11 commits intogoharbor:mainfrom
bupd:fix-cp-pull
Jan 26, 2026
Merged

Fix: Copy Pull Button when tags are undefined#22136
Vad1mo merged 11 commits intogoharbor:mainfrom
bupd:fix-cp-pull

Conversation

@bupd
Copy link
Copy Markdown
Contributor

@bupd bupd commented Jul 2, 2025

Comprehensive Summary of your change

  • Adds logic to not show Copy Pull Button for chart when tags are undefined / no tags
  • Added tests

Issue being fixed

Screenshots

  • Copy Button is not displayed for helm charts when there is no tags.

Screenshot_2025-07-02_05-56-33

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/update"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

bupd added 3 commits July 2, 2025 05:26
* Adds logic to not show copy button when tags undefined

Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
@bupd bupd requested a review from a team as a code owner July 2, 2025 00:25
@bupd
Copy link
Copy Markdown
Contributor Author

bupd commented Jul 2, 2025

Looks like the tests are flaky. hope rerunning them should fix it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.89%. Comparing base (c8c11b4) to head (556a494).
⚠️ Report is 645 commits behind head on main.

Files with missing lines Patch % Lines
...ct-list-tab/pull-command/pull-command.component.ts 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22136       +/-   ##
===========================================
+ Coverage   45.36%   65.89%   +20.52%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116563   +103230     
  Branches     2719     2939      +220     
===========================================
+ Hits         6049    76812    +70763     
- Misses       6983    35492    +28509     
- Partials      301     4259     +3958     
Flag Coverage Δ
unittests 65.89% <72.72%> (+20.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ct-list-tab/pull-command/pull-command.component.ts 54.05% <72.72%> (+41.55%) ⬆️

... and 988 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OrlinVasilev OrlinVasilev added the release-note/update Update or Fix label Aug 20, 2025
@bupd
Copy link
Copy Markdown
Contributor Author

bupd commented Aug 22, 2025

/label "target/2.14.1"

@harbor-maintainers

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions Bot added Stale and removed Stale labels Nov 7, 2025
@bupd
Copy link
Copy Markdown
Contributor Author

bupd commented Nov 24, 2025

/label "never-stale"

cc. @Vad1mo

@bupd
Copy link
Copy Markdown
Contributor Author

bupd commented Nov 24, 2025

@wy65701436 this is a long standing fix and should have been merged in the 2.14.1.

@Vad1mo Vad1mo enabled auto-merge (squash) January 22, 2026 11:58
@Vad1mo Vad1mo merged commit 7f2309a into goharbor:main Jan 26, 2026
12 checks passed
sias32 pushed a commit to sias32/harbor that referenced this pull request Feb 1, 2026
* fix: not show pullcommand for chart when tag is undefined

* Adds logic to not show copy button when tags undefined

Signed-off-by: bupd <bupdprasanth@gmail.com>

* feat: add tests to ensure pull cmd for undefined tags

Signed-off-by: bupd <bupdprasanth@gmail.com>

* fix: redundant logic

Signed-off-by: bupd <bupdprasanth@gmail.com>

---------

Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: sias32 <sias.32@yandex.ru>
sias32 pushed a commit to sias32/harbor that referenced this pull request Feb 2, 2026
* fix: not show pullcommand for chart when tag is undefined

* Adds logic to not show copy button when tags undefined

Signed-off-by: bupd <bupdprasanth@gmail.com>

* feat: add tests to ensure pull cmd for undefined tags

Signed-off-by: bupd <bupdprasanth@gmail.com>

* fix: redundant logic

Signed-off-by: bupd <bupdprasanth@gmail.com>

---------

Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: sias32 <sias.32@yandex.ru>
sias32 pushed a commit to sias32/harbor that referenced this pull request Feb 5, 2026
* fix: not show pullcommand for chart when tag is undefined

* Adds logic to not show copy button when tags undefined

Signed-off-by: bupd <bupdprasanth@gmail.com>

* feat: add tests to ensure pull cmd for undefined tags

Signed-off-by: bupd <bupdprasanth@gmail.com>

* fix: redundant logic

Signed-off-by: bupd <bupdprasanth@gmail.com>

---------

Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: sias32 <sias320@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide the copy button for untagged Chart Artifacts

5 participants