Refactor JavaScript integration and improve code readability.#164
Refactor JavaScript integration and improve code readability.#164fire merged 1 commit intogodotjs:gd4-rebasefrom
Conversation
|
I approved the github actions. Been busy so if someone can continue the work on #156 that'll be amazing. |
|
I think the js debugger is still being used so the build complains about needing it. |
|
@fire the pipeline is running now The first run takes very long especially for Please squash this branch before merging, I added a lot of testing commits because of the pipeline, we don't need them in the history I propose merging the open PRs to have a working |
|
Can you squash? I want to keep attribution intact |
6184ea1 to
70b9c21
Compare
We have refactored the JavaScript integration to make it more efficient. We have also improved the readability of the code by adding comments and restructuring the code blocks. This will make it easier for other developers to understand and contribute to the project. Co-Authored-By: NicolasMerget <Nicolas.Merget@deutschebahn.com>
|
Thanks |
Hey, I'm not into C++ so I did some try/error to fix the issues for the CI.
Update
.github/actions:workflow_callto reuse it for better maintenance (I going to open up an issue with my suggestions)linuxbuilds by removingwerror=yes, which could be enabled again but Wno-error="cast-function-type" didn't work withSCONSFLAGSremoving/changing issues inside the ci:
This branch should be squashed 👍