Changed gen-files' encoding to UTF-8 and updated README.md#10
Merged
Geequlim merged 2 commits intogodotjs:masterfrom Apr 10, 2020
Teashrock:master
Merged
Changed gen-files' encoding to UTF-8 and updated README.md#10Geequlim merged 2 commits intogodotjs:masterfrom Teashrock:master
Geequlim merged 2 commits intogodotjs:masterfrom
Teashrock:master
Conversation
Teashrock
changed the title
Geequlim
requested changes
Mar 5, 2020
|
|
||
| if env['tools']: | ||
| with open("tools/godot.d.ts.gen.cpp", "w") as f: | ||
| with open("tools/godot.d.ts.gen.cpp", "w", encoding="utf-8") as f: |
Collaborator
There was a problem hiding this comment.
Python2 does not support this kind of syntax. Which is the default python version on macOS.
There was a problem hiding this comment.
Godot 3.2 is now only compileable with Python 3.5+
http://docs.godotengine.org/en/3.2/development/compiling/compiling_for_osx.html
Contributor
Author
There was a problem hiding this comment.
Not only on Mac OS X, other systems too. So, now there is no need to remake that for Python 2.
| * Clone the source code of [godot](https://github.com/godotengine/godot) | ||
| * Clone this module and put it into `godot/modules/` and make sure the folder name of this module is `ECMAScript` | ||
| * [Recompile godot engine](https://docs.godotengine.org/en/3.0/development/compiling/index.html) | ||
| * [Recompile godot engine](https://docs.godotengine.org/en/3.2/development/compiling/index.html) <b>(Only MinGW is supported on Windows for now!)</b> |
Collaborator
There was a problem hiding this comment.
using **Bold content** in markdown instead of <b></b>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9. Also changed docs link to 3.2 on added statement about MinGW building.