CI: Wait for static check results before starting builds - #65232
Conversation
a5fd573 to
f8fbd41
Compare
|
@yedpodtrzitko Can you rebase this for a good measure? |
f8fbd41 to
36beb34
Compare
|
@YuriSizov done |
|
@yedpodtrzitko click "Show all checks" at the bottom of this PR. Or see the sidebar of https://github.com/godotengine/godot/actions/runs/4608607317. Currently, this PR drops the icons and a third of the space is used by 'Tiered Pipeline Runner'. |
|
I rest my case. I'm just gonna do the rebase as requested and leave the decision to maintainers. |
|
@yedpodtrzitko fair enough. Please do edit the first message to explain the reason for dropping the icons. |
|
For clarification, #75333 is about the priority of the hardcoded/static content in parens vs the dynamically generated content also in parens or in italics. This PR is introducing a prefix that hides both the static and the dynamic content. |
For the record, Akien and I agree that we shouldn't lose the icons and that we should use short names so that the checklist is readable. So suggestions by @umarcor above are indeed welcome. |
9b3779e to
93b7bcb
Compare
|
ok it should be done. thanks @umarcor |
|
Thanks! |
|
Cherry-picked for 4.0.3. |
|
Cherry-picked for 3.6. |
|
Cherry-picked for 3.5.3. |
// Another attempt for what did not work in #65123
The CI workflow "📊 Static Checks" checks code formatting etc. and even if all the build workflows in pipeline are successful, the pipeline needs to be eventually re-run in case this one fails. From what I understand the bottleneck for the CI pipeline is the number of available workers which can run builds, so it would make sense to not run the "expensive" jobs unless the basic one is successful.
Unfortunately it's impossible to make various workflow files depend on each other, so the approach here utilizes Reusable Workflows:
runner.ymlas an entrypoint for the pipelineThis means builders wont be shown separately in the Actions Tab, since they are now treated as a part of the Runner workflow. That makes it easier to cancel the whole build with a single click (a minuscule case, but still a nice thing to have) and it declutters the content there to a single row only per each git push. But that also means you cant see or filter the build types (ios, android...) there directly.