Make build_library=no usable at godot-cpp's root#903
Merged
Conversation
akien-mga
added
bug
Faless
approved these changes
Dec 19, 2022
Faless
left a comment
Faless
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 .
@PapyChacal can you squash the commits into a single one? See https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase
…_library=no. Use env variable to pass the output dir instead. Add a CI step to guard regression on this. Clean the generated sources to avoid interfering with next steps.
PapyChacal
force-pushed
the
build_library
branch
from
December 19, 2022 21:22
faa76a8 to
e52d4b6
Compare
Contributor
Author
|
Sure, done! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Currently,
build_library=nodoes not work at the repository's root. (It generates a dependency cycle and scons refuses to generate anything).To reproduce:
scons generate_bindings=yes build_library=noingodot-cppOr
rm gen -rbeforescons build_library=noingodot-cppShould give something like:
This PR solves this, by not stating that
gen/is a target itself.Also invert arguments to env.Clean, to call it as is documented in https://scons.org/doc/4.4.0/HTML/scons-user/apd.html.
I added a CI step to check this does not regress. I clean the generated sources before the actual build, to make sure the build step includes generation so the dependency handling should not regress either.