Add Object::cast_to for const Object*#849
Merged
Merged
Conversation
aaronfranke
approved these changes
Sep 18, 2022
Member
|
Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Sounds like you might have omitted regenerating the bindings? But it also means that the auto-detection that the bindings do need to be regenerated is not properly taking into account the |
Member
|
Sorry for the confusion, you're right, a |
Member
79 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before it wasn't possible to use
Object::cast_to(obj)ifobjwas aconst T*. Godot does the same thing: https://github.com/godotengine/godot/blob/908795301b9e4fcf24b115329a48d7d295c13a1a/core/object/object.h#L734-L764