Skip to content

Add Object::cast_to for const Object*#849

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
Zylann:const_cast_to
Sep 19, 2022
Merged

Add Object::cast_to for const Object*#849
akien-mga merged 1 commit into
godotengine:masterfrom
Zylann:const_cast_to

Conversation

@Zylann

@Zylann Zylann commented Sep 18, 2022

Copy link
Copy Markdown
Collaborator

Before it wasn't possible to use Object::cast_to(obj) if obj was a const T*. Godot does the same thing: https://github.com/godotengine/godot/blob/908795301b9e4fcf24b115329a48d7d295c13a1a/core/object/object.h#L734-L764

@akien-mga
akien-mga merged commit d4cef0b into godotengine:master Sep 19, 2022
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@aaronfranke

This comment was marked as resolved.

@akien-mga

akien-mga commented Sep 19, 2022

Copy link
Copy Markdown
Member

Sounds like you might have omitted regenerating the bindings?

But it also means that the auto-detection that the bindings do need to be regenerated is not properly taking into account the binding_generator.py file as a dependency. (CC @Faless)

@aaronfranke

Copy link
Copy Markdown
Member

Sorry for the confusion, you're right, a git clean fixed it. Still good to look into it not auto-regenerating.

@akien-mga

Copy link
Copy Markdown
Member

But it also means that the auto-detection that the bindings do need to be regenerated is not properly taking into account the binding_generator.py file as a dependency. (CC @Faless)

So this was actually fixed by #838.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants