Fix _THREAD_SAFE_CLASS_ and related macros#2026
Open
dsnopek wants to merge 1 commit into
Open
Conversation
Ivorforce
reviewed
Jul 26, 2026
| namespace godot { | ||
|
|
||
| class MutexLock { | ||
| const Mutex &mutex; |
Member
There was a problem hiding this comment.
This will fix the issue I think, but...
I think we should sync Mutex over directly instead and push Mutex into a CoreBind namespace.
The CoreBind Mutex only really exists for scripting languages that can't do better. I can't think of a reason to use the CoreBind one instead of the template one; it's not allowed to be allocated locally (which was violated here), and it's way slower too.
Collaborator
Author
There was a problem hiding this comment.
Yeah, that's an option!
I had thought we were using a lot of OS-specific code in Mutex but reading it now, it's mostly std::mutex (except on mingw) so syncing should be fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2020
This also adds some tests, so hopefully, we won't break it again later