Skip to content

Sync LocalVector with upstream Godot#2016

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
Ivorforce:localvector-10.x
Jul 24, 2026
Merged

Sync LocalVector with upstream Godot#2016
dsnopek merged 1 commit into
godotengine:masterfrom
Ivorforce:localvector-10.x

Conversation

@Ivorforce

Copy link
Copy Markdown
Member

Another copy-paste job with some compilation fixes after :)

Includes #2012, #2013, #2014, #2015 out of necessity.

@Ivorforce
Ivorforce requested a review from a team as a code owner July 5, 2026 09:39
@Ivorforce Ivorforce added the enhancement This is an enhancement on the current functionality label Jul 5, 2026
@dsnopek

dsnopek commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

This sync appears to be missing some recent Godot changes:

I don't know if it's important to try and catch those in this PR? We can't have this PR chase Godot endlessly :-)

@Ivorforce

Copy link
Copy Markdown
Member Author

Those were added after my PR :D
Both aren't critical, but I can add them if you prefer.

@dsnopek

dsnopek commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Up to you! I'd be fine with that in a follow up

@Ivorforce

Copy link
Copy Markdown
Member Author

Sounds good to me. I'd like to skip it for now to avoid the rebases down the line.

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but needs a rebase

@dsnopek dsnopek added this to the 10.x milestone Jul 24, 2026
@dsnopek
dsnopek merged commit 64b9a43 into godotengine:master Jul 24, 2026
20 checks passed
@dsnopek

dsnopek commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

@Ivorforce
Ivorforce deleted the localvector-10.x branch July 24, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants