Skip to content

CMake: Rename all GODOT_ to GODOTCPP_#1721

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
enetheru:godotcpp
Mar 1, 2025
Merged

CMake: Rename all GODOT_ to GODOTCPP_#1721
dsnopek merged 1 commit into
godotengine:masterfrom
enetheru:godotcpp

Conversation

@enetheru

Copy link
Copy Markdown
Collaborator

This is for discussion primarily at this stage.

While I've been working on other random projects, it comes up that they have their projects setup to build godot so that they can debug the editor and their gdextension at the same time.

This does create a sort of name clash where it ends up feeling confusing that the variables used GODOT_ are for the bindings, and not for the engine.

So I'm just putting this out there, to see what others thoughts are.

@dsnopek

dsnopek commented Feb 26, 2025

Copy link
Copy Markdown
Collaborator

Personally, I think your reasoning for switching to GODOTCPP_ makes sense.

And, if we're going to do it, doing it before the 4.4 release is the best time, because developers will already have to adapt to all the other cmake related changes. I'd be less inclined to make the change later, where we'd be forcing developers to update their cmake configuration right after we just made them do that.

@enetheru
enetheru marked this pull request as ready for review February 27, 2025 21:46
@enetheru
enetheru requested review from a team as code owners February 27, 2025 21:46
@Calinou Calinou added the enhancement This is an enhancement on the current functionality label Feb 27, 2025

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unless anyone objects in the next ~24 hours, I think we should go for this.

However, this is missing updates in the doc/cmake.rst to show the renamed variables. If you have a chance to add that before it's merged, that'd be great, otherwise I can add that myself too.

This is for discussion primarily at this stage.
@dsnopek
dsnopek merged commit 06082d7 into godotengine:master Mar 1, 2025
@enetheru
enetheru deleted the godotcpp branch March 1, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants