CMake: Replace empty ${EXCLUDE} variable with EXCLUDE_FROM_ALL#1660
Merged
Conversation
enetheru
force-pushed
the
exclude_typo
branch
from
November 28, 2024 15:15
f0f5860 to
2430ade
Compare
enetheru
marked this pull request as ready for review
November 30, 2024 05:36
dsnopek
approved these changes
Dec 2, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Looks good to me :-)
This was a mistake left over from the modernise PR
enetheru
force-pushed
the
exclude_typo
branch
from
December 4, 2024 22:46
2430ade to
9df3a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a mistake left over from the modernise PR
Left over from when I had a default target of template_debug, but it still wanted to build even if it was not depended on.
the targets should be excluded so that they dont all build all the time.