Mark return value of get_class_static and get_parent_class_static as const.#1463
Merged
dsnopek merged 1 commit intoMay 17, 2024
Conversation
AThousandShips
added
enhancement
dsnopek
added
cherrypick:4.1
cherrypick:4.2
and removed
topic:buildsystem
dsnopek
approved these changes
May 17, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this looks great to me!
Collaborator
|
Cherry-picked for 4.2 in PR #1465 |
Collaborator
|
Cherry-picked for 4.1 in PR #1466 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the commet in #1446 .