[iOS] Fix initialisation/termination of multiple statically linked extensions.#1316
Merged
Merged
Conversation
dsnopek
approved these changes
Nov 22, 2023
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This looks good to me :-)
|
Will this be in v4.2? |
|
The static init_callback is called for every loaded extensions. Then every extension's initializer is called multiple times. Why not use a member variable for init_callback? |
bruvzg
marked this pull request as draft
November 23, 2023 07:13
Member
Author
Yes, this seems to be the case. Will fix a bit later. |
bruvzg
force-pushed
the
static_multiple_init
branch
from
November 23, 2023 11:38
2e444e1 to
adc9def
Compare
bruvzg
marked this pull request as ready for review
November 23, 2023 11:38
|
This works. |
Member
|
Thanks! |
Collaborator
|
Cherry-picking to 4.1 in #1373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes godotengine/godot#85210, with a statically linked extensions this part is shared between all extensions and therefor can use static variables.