Skip to content

{cmake} Add GODOT_CPP_SYSTEM_HEADERS option to mark includes as SYSTEM - #1002

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
asmaloney:cmake-system-includes
Jan 19, 2023
Merged

{cmake} Add GODOT_CPP_SYSTEM_HEADERS option to mark includes as SYSTEM#1002
akien-mga merged 1 commit into
godotengine:masterfrom
asmaloney:cmake-system-includes

Conversation

@asmaloney

Copy link
Copy Markdown
Contributor

From the cmake docs:

This may have effects such as suppressing warnings or skipping the contained headers in dependency calculations (see compiler documentation). Additionally, system include directories are searched after normal include directories regardless of the order specified.

Addresses part of #999

From the cmake docs:

"This may have effects such as suppressing warnings or skipping the contained headers in dependency calculations (see compiler documentation). Additionally, system include directories are searched after normal include directories regardless of the order specified."

Addresses part of godotengine#999
@asmaloney
asmaloney requested a review from a team as a code owner January 19, 2023 02:16
@akien-mga akien-mga added enhancement This is an enhancement on the current functionality cmake topic:buildsystem Related to the buildsystem or CI setup labels Jan 19, 2023
@akien-mga
akien-mga merged commit 952bde1 into godotengine:master Jan 19, 2023
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@asmaloney
asmaloney deleted the cmake-system-includes branch January 19, 2023 12:59
@asmaloney
asmaloney restored the cmake-system-includes branch January 19, 2023 12:59
@asmaloney
asmaloney deleted the cmake-system-includes branch January 19, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants