fix: do not report unset error for ignored or untagged fields when ErrorUnset is enabled - #202
Open
wwww-deeeee wants to merge 1 commit into
Open
wwww-deeeee wants to merge 1 commit into
wwww-deeeee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mitchellh#350: ErrorUnset conflicts with UntaggedFields / ignored fields.
Root Cause
When
ErrorUnset: trueis set,decodeStructiterates over struct fields. For fields withmapstructure:"-"tag (or untagged fields whenIgnoreUntaggedFields: true), the field was not skipped. Instead,fieldNamewas set to"-", leading to a lookup in the map that failed, causing the field to be added totargetValKeysUnusedand reporting'...' has unset fields: -.Changes
decodeStruct, skip fields wheretagValue == "-"or(tagValue == "" && d.config.IgnoreUntaggedFields).mapstructure_test.go:TestDecoder_ErrorUnset_IgnoredFieldTestDecoder_ErrorUnset_IgnoredFieldWithConfigTestDecoder_ErrorUnset_IgnoredUntaggedFieldgo test ./...->ok.