Remote Taskfiles: redact credentials of remote URLs in prompts and logs - #2045
Closed
iwittkau wants to merge 2 commits into
Closed
Remote Taskfiles: redact credentials of remote URLs in prompts and logs#2045iwittkau wants to merge 2 commits into
iwittkau wants to merge 2 commits into
Conversation
iwittkau
commented
Feb 6, 2025
pd93
reviewed
Feb 7, 2025
iwittkau
changed the title
iwittkau
commented
Feb 9, 2025
iwittkau
marked this pull request as draft
February 9, 2025 10:38
Contributor
Author
|
I've turned this into a draft for now. |
iwittkau
commented
Feb 9, 2025
|
|
||
| func (node *GitNode) FilenameAndLastDir() (string, string) { | ||
| return filepath.Base(node.path), filepath.Base(filepath.Dir(node.path)) | ||
| return filepath.Base(filepath.Dir(node.filepath)), filepath.Base(node.filepath) |
Contributor
Author
There was a problem hiding this comment.
taskfile/cache.go uses it like this:
lastDir, filename := node.FilenameAndLastDir()
iwittkau
force-pushed
the
redact-git-urls
branch
2 times, most recently
from
February 9, 2025 20:58
03a5551 to
3fc6d75
Compare
iwittkau
marked this pull request as ready for review
February 9, 2025 21:02
Contributor
Author
|
Compiling it and running this as a development version actually breaks my own git-based Remote Taskfiles setup 😅 Back to draft, I guess. |
iwittkau
marked this pull request as draft
February 10, 2025 11:27
iwittkau
commented
Feb 10, 2025
iwittkau
force-pushed
the
redact-git-urls
branch
from
February 14, 2025 08:01
3fc6d75 to
6a3da1a
Compare
iwittkau
force-pushed
the
redact-git-urls
branch
2 times, most recently
from
March 11, 2025 09:37
8b53b31 to
8d0a6cd
Compare
iwittkau
force-pushed
the
redact-git-urls
branch
from
March 12, 2025 21:28
8d0a6cd to
7f6737a
Compare
iwittkau
force-pushed
the
redact-git-urls
branch
from
March 12, 2025 21:31
7f6737a to
cf8d60b
Compare
iwittkau
marked this pull request as ready for review
March 12, 2025 21:35
Contributor
Author
|
I don't think it makes sense to keep this open. A lot of the affected code was changed in the meantime. I think it would make more sense to think about URL redaction in the final stages of the experiment when the code has become more stable. |
Member
|
Hi @iwittkau. Sorry for that. As you said, the code is changing a lot at the moment so things often go out of date very quickly. Thanks for your time though. Hopefully the conversation and changes here are still a useful reference to anyone implementing this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to improve #1317.
I've implemented redaction support for the
taskfile.Nodeinterface, specifically for thetaskfile.GitNodeimplementation which was logged with the clear-text user access tokens before.