fix: concurrent omap reads - #1608
Closed
pd93 wants to merge 1 commit into
Closed
Conversation
trim21
reviewed
Apr 22, 2024
| if om.m == nil { | ||
| om.m = make(map[K]V) | ||
| } | ||
| if om.mutex == nil { |
Contributor
There was a problem hiding this comment.
Doesn't look right, there is still a race condition here. Otherwise this if branch is a no-op
Member
There was a problem hiding this comment.
Yes, we should likely instantiate this mutex on the New function.
Contributor
|
how about this: https://gist.github.com/trim21/0e5fd4ae16a393f471290d1d7e609a0c （some tests need to be updated for this approach） |
andreynering
requested changes
May 9, 2024
andreynering
left a comment
andreynering
left a comment
Member
There was a problem hiding this comment.
Let's try to instantiate the mutex in a centralized manner on the New constructor.
Closed
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1605
Adds a mutex to
omap.OrderedMapso that it is safe for use in goroutines.