fix: operator-method call names (regression from Round 4) - #7
Merged
Conversation
methodName lumped every operator token together with the backtick XSTRING case and unconditionally returned "`", so `1.+(2)`, `a.<=>(b)`, `obj.&(x)` and every other explicit operator-method call parsed with method name "`" instead of the operator. The existing tests only asserted these *parse*, not their resulting name, so the regression went unnoticed. Split the XSTRING (backtick-method) case out and return the operator token's own spelling (t.Type.String()) for the operator cases. Add TestOperatorMethodName asserting the parsed Call.Name for each operator, plus the empty-backtick method, keeping methodName at 100% coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 4 regressed
methodName: it returned"`"(backtick) for every explicit operator-method call (1.+(2),a.<=>(b)…), so they'd dispatch to the wrong method. Fix: uset.Type.String()for operator tokens, reserving the backtick name for the empty-XSTRING case. Adds a name-asserting test; 100% coverage.🤖 Generated with Claude Code