feat(lexer): preserve the /o "interpolate once" regexp flag - #10
Merged
Conversation
The lexer collected only i/m/x from a regexp literal's trailing flags and
silently dropped o (and the encoding flags). Downstream VMs need /o to
implement Ruby's "interpolate once" semantics — compile an interpolated
literal a single time and reuse that object — so preserve o in Flags at both
the /…/ and %r{…} scan sites. Encoding flags (n/u/e/s) stay consumed-but-
unrecorded, unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lexer collected only
i/m/xfrom a regexp literal's trailing flags and silently droppedo(the "interpolate once" flag). Downstream VMs need/oto implement Ruby's semantics — compile an interpolated literal a single time and reuse that object even as the interpolated values change.This preserves
oinFlagsat both scan sites (/…/and%r{…}). Encoding flags (n/u/e/s) stay consumed-but-unrecorded, unchanged.Tests
/a#{x}b/io→ Flagsio%r{a#{x}b}mo→ Flagsmo/x/n→ Flags `` (encoding flag still dropped)100% coverage gate green locally.
🤖 Generated with Claude Code