Repository navigation
Feat: uds_exists validator - #1482
Merged
zemzale merged 5 commits intoDec 23, 2025
Merged
Conversation
barash-asenov
marked this pull request as draft
October 31, 2025 07:39
barash-asenov
changed the title
barash-asenov
force-pushed
the
bux-unix-addr-is-useless
branch
2 times, most recently
from
October 31, 2025 12:19
89dc794 to
94e0bfc
Compare
barash-asenov
marked this pull request as ready for review
October 31, 2025 12:21
barash-asenov
force-pushed
the
bux-unix-addr-is-useless
branch
from
October 31, 2025 12:31
94e0bfc to
4b86d5b
Compare
zemzale
previously approved these changes
Dec 4, 2025
zemzale
left a comment
zemzale
left a comment
Member
There was a problem hiding this comment.
I would like the tests to be cleaner, but otherwise looks good
barash-asenov
force-pushed
the
bux-unix-addr-is-useless
branch
from
December 14, 2025 13:33
fbd77fd to
6d339b6
Compare
zemzale
previously approved these changes
Dec 19, 2025
deankarn
previously approved these changes
Dec 21, 2025
deankarn
left a comment
deankarn
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left one question
| - varnamelen | ||
| - wrapcheck | ||
| - wsl | ||
| - modernize |
Contributor
There was a problem hiding this comment.
Curious why this is required?
Contributor
Author
There was a problem hiding this comment.
I see #1487 already excluded this linter. Therefore actually not really required anymore. I will do the adjustment.
barash-asenov
force-pushed
the
bux-unix-addr-is-useless
branch
from
December 22, 2025 11:51
7cb79fc to
659afce
Compare
Contributor
Author
|
I think I should've avoided rebasing.. |
zemzale
approved these changes
Dec 23, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers
As discussed in: #1348