Repository navigation
Conversation
Preserve the existing pilot admission contract with disposable Git fixtures: block external dirt before dispatch, independently require ready specs, and retain the .flow bookkeeping exemption. Adapt the original regression coverage from 9984078 with generic fixture paths.
There was a problem hiding this comment.
🟢 Approval recommended
The focused tests cover existing guard behavior, no blocking issues remain, and the linked CI run succeeded for the final candidate.
No open issues 🎉
What changed in this PR
Adds regression tests for existing flow --auto admission guards without changing runtime behavior.
Changes:
- Covers ready-spec selection and unready-spec ineligibility.
- Verifies dirty trees stop before dispatch without modifying fixture files or the strike ledger.
- Confirms tracked
.flow/changes remain exempt from the dirty guard.
| File | Description |
|---|---|
plugins/flow-next/tests/test_pilot_guard_safety.py |
Adds five snapshot and shell-guard tests using disposable Git/Flow fixtures. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cover existing
flow --autoadmission guards without changing runtime behavior.Coverage
.flow/spec appears in Git status but remains exempt from the dirty guard. The clean-ready case covers untracked.flow/state.Two shell-guard tests require POSIX Bash and
jqand skip on Windows; the other three snapshot tests run cross-platform.Validation
.flowcorrection: 219 files, 4,075 tests, 0 failures, 0 errors, 7 skipped.This test originated in commit
9984078cby Julien Carosi; attribution is retained. Independent Opus implementation review returned SHIP on1858ff7f; the scoped re-review returned SHIP with no new findings on final candidate929c6d9ce4142c121b465e477c9966554ecbb802.Hosted CI passed on
929c6d9c: aggregate, Linux/macOS/Windows units, three OS smokes, and Python compatibility. Its Windows interpreter stub was intentionally skipped for this tests-only change (run #40117773995). CI covers the final candidate; the full local suite above predates the.flowcorrection.