Skip to content

GLOSSARY() recomputes the slot collapse once per witness #23

Description

@phas02

What it buys: one slot collapse per read.

What stands: no store relation is re-scanned per call —
Store::read_context is cached by version
(crates/glossary/src/store.rs:1570-1592) and Store::history per
relation snapshot (store.rs:1402-1434). The cost is in-memory
recompute: Store::slots (store.rs:898) runs once per witness with
a detector inside raw_read (crates/session/src/reads.rs:239) plus
once in collapsed_read (store.rs:1057), each pass re-filtering
the whole history; verdicts re-reads witnesses_all()
(reads.rs:229) though ctx.witnesses holds the rows;
read_context computes the pin and the version before its cache
check (store.rs:1571-1572); each detector run builds a fresh
SessionContext (reads.rs:299-300).

Done when: the slots are computed once per read and shared across
witnesses and the collapse; the witnesses come from the context; the
cache check precedes the pin.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    debtKnown shortfall in shipped behavior

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions