Add nested unordered list items#31
Merged
Canedo merged 8 commits intoglobocom:masterfrom Feb 26, 2018
Yoruba:master
Merged
Conversation
Collaborator
|
Hey @Yoruba ! I updated all devDependencies and fixed some CI and automatization on the project. But with your PR our coverage dropped a little bit. Do you mind trying to create a few unit test to check your logic on these files? |
Collaborator
|
Hey @Yoruba . It's looking great! I'll release a new version this week with your PR. I'll let you know when i'm done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for unordered list items. See link for issue.
Maybe the code is write to defensive.
Normally there is always a depth and unorderedListItemCustomStyleBullet.
It was added to pass the test.