fix: surface config save errors instead of silently swallowing them - #89
Merged
Conversation
steve-calvert-glean
force-pushed
the
fix-config-save-errors
branch
from
April 12, 2026 17:18
b2a4f7f to
93d2954
Compare
rwjblue-glean
approved these changes
Apr 12, 2026
SaveConfig() previously only returned an error when both keyring and file writes failed. Now logs independently when one backend fails. Also fixes AddTurn()/AppendTurn() to return save errors instead of silently logging them.
steve-calvert-glean
force-pushed
the
fix-config-save-errors
branch
from
April 12, 2026 18:37
93d2954 to
faf03cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SaveConfig()previously only returned an error when both keyring and file writes failed — now logs independently when one backend failsAddTurn()andAppendTurn()now return save errors instead of silently logging themTest plan
mise run test:allpasses (452 tests, lint clean, binary builds)