feat: warn on unknown config keys to catch typos - #88
Merged
Conversation
steve-calvert-glean
force-pushed
the
config-key-validation
branch
from
April 12, 2026 17:18
5fb57d5 to
5f0fb48
Compare
rwjblue-glean
approved these changes
Apr 12, 2026
rwjblue-glean
left a comment
rwjblue-glean
left a comment
Member
There was a problem hiding this comment.
Seems good. I do think we might want to ignore a config that has invalid keys, thoughts?
Adds validation in config loading that checks for unknown JSON keys and logs warnings via the config:load debug namespace. Visible with -v or GLEAN_DEBUG=config:*.
steve-calvert-glean
force-pushed
the
config-key-validation
branch
from
April 12, 2026 18:34
5f0fb48 to
10d21f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateConfigKeys()that checks for unknown JSON keys when loading configconfig:loaddebug namespace (visible with-vorGLEAN_DEBUG=config:*)Test plan
"toke"produces warningmise run test:allpasses (455 tests, lint clean, binary builds)