feat: improve search response cleansing with expanded allowlists - #76
Merged
Merged
Conversation
…snapshot tests - Expand metadata allowlist: owner, assignedTo, updatedBy, status, priority, container, datasourceId - Fix snippet field: use "text" instead of deprecated "snippet" key - Trim person allowlist: drop "email" (not present in API responses) - Filter empty snippets: remove snippets with blank/missing text - Add snapshot tests with real-world fixtures (people, jira, github, mixed queries) and structural validation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rwjblue-glean
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #71. Improves the search response cleansing logic based on real API response analysis:
owner,assignedTo,updatedBy,status,priority,container,datasourceId— these are useful fields present in Jira, GitHub, and other datasource responsestextinstead of deprecatedsnippetkey to match actual API responsesemail(not present in search API responses), keeping onlynametextto avoid noisy empty entriesTest plan
go test ./internal/output/ -run Cleanse -v— all 10 tests pass🤖 Generated with Claude Code