fix: normalize host in resolveHost to prevent token lookup mismatch - #72
Merged
steve-calvert-glean merged 1 commit intoApr 3, 2026
Merged
Conversation
When GLEAN_HOST is set to a short form (e.g. "acme" instead of "acme-be.glean.com"), persistLoginState normalizes it in the config file via SaveHostToFile, but SaveTokens hashes the un-normalized value. On the next session, LoadConfig returns the normalized host from the config file, but LoadTokens looks under a different hash directory — tokens not found. Fix by normalizing the host in resolveHost before returning it, so all downstream callers (token storage, config persistence) use the same consistent value. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveHostso that short-formGLEAN_HOSTvalues (e.g.acme) don't cause a hash mismatch between token storage and token lookupProblem
When
GLEAN_HOST=acme(short form):resolveHostreturns"acme"(raw from env)persistLoginState→SaveHostToFile("acme")normalizes to"acme-be.glean.com"in configSaveTokens("acme", tok)hashes un-normalized"acme"LoadConfigreturns"acme-be.glean.com",LoadTokensuses a different hash → tokens not foundFix
One-line change:
resolveHostnow returnsconfig.NormalizeHost(cfg.GleanHost)instead ofcfg.GleanHost, ensuring all downstream callers use the same normalized value.Test plan
go test ./internal/auth/...— 23 tests pass (including newTestShortFormHostNormalizesConsistently)go test ./...— 354 tests passgolangci-lint run— no issues🤖 Generated with Claude Code