Skip to content

Missing env keys and optional chaning in process.env causing unusual errors #24

Description

@Nabhag8848

Description

  • As there is current addtion of slack integration, env keys ( just keys not value ) related to slack are missing, causing application with errors when running whole application npm run dev . Following keys are missing in .env.example.
SLACK_CLIENT_ID=
SLACK_CLIENT_SECRET=
SLACK_SIGNING_SECRET=
SLACK_SOCKET_TOKEN=
SLACK_APP_ID=

  • Didn't started stable as the redirect destination of /docs isn't defined. for fixing this we need to define a default port (ie: 8080 ) to start docs and add flag --port <number> for npm run docs
--- other env keys
DOCS_URL=`http://localhost:8080` (for local)
  • There are places where env variables are accessed using optional chaning which never will be optional, causing usual crash.

Screenshots

  • Slack key error:
ss
  • Missing docs key
ss 1

Additional information

  • Willingly need to contribute, As this are unrelated issue but small, do you need me to make different PRs or bundle up in same with different commits would be fine ?
  • is the idea about docs giving default port Looks good to you ? or am i missing something in future plans ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions