Fix cloning to path with unicode#955
Merged
Byron merged 1 commit intogitpython-developers:masterfrom Oct 28, 2019
Merged
Conversation
Byron
approved these changes
Oct 28, 2019
Member
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for improving yet another instance of GitPython's confused way of handling encodings.
For a moment I thought maybe it's generally helping if force_bytes would default its encoding keyword parameter to utf-8 instead of ascii, since ascii is a valid subset of utf-8, i.e. all ascii files are also utf-8 encoded files.
Then I was uncertain if it would actually end up working that way. Your advice is appreciated, maybe it's worth another PR if you think it should work.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cloning to directories with a path containing Unicode characters
Closes issue #920