Fix/deepsource issues#952
Conversation
…nto fix/deepsource-issues
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for your continued contribution to this project.
Even though I would love to merge, I think it's more important to not break the interface than to satisfy deepsource. Thus I would be great if there could be another solution. Thank you.
Byron
left a comment
There was a problem hiding this comment.
Thank a lot for fixing the issue found in first review, your continued effort is much appreciated.
Now it looks like there is only one small fix to be made and conflicts to be resolved before it can be merged.
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
+ Coverage 93.52% 93.53% +0.01%
==========================================
Files 59 59
Lines 9677 9680 +3
==========================================
+ Hits 9050 9054 +4
+ Misses 627 626 -1
Continue to review full report at Codecov.
|
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution! I can't wait to see deepsource happy one day :).
I will continue with this further.