Skip to content

refactor: switch RepositoryScreen to styled components #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machour merged 2 commits into from
Apr 30, 2018
Merged

refactor: switch RepositoryScreen to styled components #788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be352c5
refactor: switch RepositoryScreen to styled components
machour Apr 24, 2018
b481bc0
Merge branch 'master' into refactor/repository-screen-sc
machour Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions src/repository/screens/repository.screen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@
import React, { Component } from 'react';
import { connect } from 'react-redux';
import styled from 'styled-components';
import {
StyleSheet,
RefreshControl,
Share,
ActivityIndicator,
} from 'react-native';
import { RefreshControl, Share, ActivityIndicator } from 'react-native';
import { ListItem } from 'react-native-elements';
import ActionSheet from 'react-native-actionsheet';
import { RestClient } from 'api';
Expand Down Expand Up @@ -74,16 +69,16 @@ const LoadingMembersContainer = styled.View`
padding: 5px;
`;

const styles = StyleSheet.create({
listTitle: {
const SectionListItem = styled(ListItem).attrs({
titleStyle: {
color: colors.black,
...fonts.fontPrimary,
},
listContainerStyle: {
containerStyle: {
borderBottomColor: colors.greyLight,
borderBottomWidth: 1,
},
});
})``;

class Repository extends Component {
props: {
Expand Down Expand Up @@ -366,15 +361,13 @@ class Repository extends Component {
{!hasError && (
<SectionList title={t('SOURCE', locale)}>
{showReadMe && (
<ListItem
<SectionListItem
title={t('README', locale)}
leftIcon={{
name: 'book',
color: colors.grey,
type: 'octicon',
}}
titleStyle={styles.listTitle}
containerStyle={styles.listContainerStyle}
onPress={() =>
navigation.navigate('ReadMe', {
repository,
Expand All @@ -383,10 +376,8 @@ class Repository extends Component {
underlayColor={colors.greyLight}
/>
)}
<ListItem
<SectionListItem
title={t('View Code', locale)}
titleStyle={styles.listTitle}
containerStyle={styles.listContainerStyle}
leftIcon={{
name: 'code',
color: colors.grey,
Expand Down