Skip to content

fix: reintroduce View to avoid list being cropped#695

Merged
housseindjirdeh merged 1 commit intogitpoint:masterfrom
machour:fix-repo-list
Jan 16, 2018
Merged

fix: reintroduce View to avoid list being cropped#695
housseindjirdeh merged 1 commit intogitpoint:masterfrom
machour:fix-repo-list

Conversation

@machour
Copy link
Copy Markdown
Member

@machour machour commented Jan 15, 2018

Question Response
Version? dev-master
Devices tested? iPhone 7
Bug fix? yes
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #694

Screenshots

Before After
simulator screen shot - iphone 6 - 2018-01-15 at 23 15 32 simulator screen shot - iphone 6 - 2018-01-15 at 23 30 44

Description

Reintroduced the <View> element removed in #683

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 43.31% when pulling c8c3eee on machour:fix-repo-list into 608818e on gitpoint:master.

Copy link
Copy Markdown
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful thank you

@housseindjirdeh housseindjirdeh merged commit e994240 into gitpoint:master Jan 16, 2018
@machour machour deleted the fix-repo-list branch January 16, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants