refactor(styles): Migrate LabelButton#613
refactor(styles): Migrate LabelButton#613josenaranjo wants to merge 1 commit intogitpoint:masterfrom
Conversation
Refactored LabelButton to render a LabelButton large or small depending on largeWithTag prop gitpoint#532
|
@josenaranjo I am afraid that it is better to keep as one component and control properties by props. For example, |
There was a problem hiding this comment.
@josenaranjo The provided screenshot doesn't showcase the LabelButton component at all.
LabelButton can be seen in a existing issue or pull request setting screen (use the cog icon to access it).
Additionally, you are dropping the off react-native-elements and using the Button from react-native, which is probably not what you want to do.
Don't hesitate if you need any help buddy :)
|
Hi @josenaranjo, friendly ping, are you still up for this one? Let us know 🙏 |
|
@josenaranjo Sorry, #727 will take over your work. But please feel free to help our project at any time in the future! |
|
#727 was merged in, closing this stale PR |
LabelButton's tests are not passing, I already tried to fix it, but didn't find the reason why it is failing. Please let me know if you have any hint.
Screenshots
Description
Refactored LabelButton to render a LabelButton large or small depending on largeWithTag prop