-
Notifications
You must be signed in to change notification settings - Fork 775
test(text-helper): add test for emojifyText, abbreviateNumber #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5f6376a
test(text-helper): add test for emojifyText, abbreviateNumber
ibotdotout c54a9cc
test(text-helper): improve it
0a4ef41
test(text-helper): add new line before expect
ibotdotout c7af126
test(text-helper): add new line after variables
ibotdotout 90467ea
test(text-helper): remove sinon -> jest for mock
ibotdotout fd2b6a6
test(text-helper): clean test case title
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { emojifyText, abbreviateNumber } from 'utils'; | ||
| import emoji from 'node-emoji'; | ||
|
|
||
| describe('Text Helper', () => { | ||
| describe('emojifyText', () => { | ||
| it('should call correcly with text params', () => { | ||
| const emojify = jest.spyOn(emoji, 'emojify'); | ||
| const input = 'I need more :coffee'; | ||
|
|
||
| emojifyText(input); | ||
|
|
||
| expect(emojify).toBeCalledWith(input); | ||
|
|
||
| emojify.mockReset(); | ||
| emojify.mockRestore(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('abbreviateNumber', () => { | ||
| it('should return 1 when given 1', () => { | ||
| const input = 1; | ||
| const expected = 1; | ||
| const result = abbreviateNumber(input); | ||
|
|
||
| expect(result).toEqual(expected); | ||
| }); | ||
|
|
||
| it('should return 1k when given 1000', () => { | ||
| const input = 1000; | ||
| const expected = '1k'; | ||
| const result = abbreviateNumber(input); | ||
|
|
||
| expect(result).toEqual(expected); | ||
| }); | ||
|
|
||
| it('should return 1.1k when given 1100', () => { | ||
| const input = 1100; | ||
| const expected = '1.1k'; | ||
| const result = abbreviateNumber(input); | ||
|
|
||
| expect(result).toEqual(expected); | ||
| }); | ||
|
|
||
| it('should return 96.2k when given 96234', () => { | ||
| const input = 96234; | ||
| const expected = '96.2k'; | ||
| const result = abbreviateNumber(input); | ||
|
|
||
| expect(result).toEqual(expected); | ||
| }); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯