style(component): Updating CodeLine component to use Styled-components#561
Merged
alejandronanez merged 3 commits intogitpoint:masterfrom Oct 23, 2017
Conversation
Deleted StyledSheet styles and migrate those to Styled-Components format. 515
alejandronanez
requested changes
Oct 23, 2017
Member
alejandronanez
left a comment
alejandronanez
left a comment
There was a problem hiding this comment.
Address the typo and this should be good to go.
Thanks!
| `; | ||
|
|
||
| const Wrapper = styled.View` | ||
| flex-directino: row; |
Member
There was a problem hiding this comment.
Can you fix this typo please, it should be flex-direction
andrewda
requested changes
Oct 23, 2017
| <SyntaxHighlighterStyled | ||
| language={language} | ||
| style={GithubStyle} | ||
| CodeTag={Text} |
Member
There was a problem hiding this comment.
You're going to need to keep Text imported for this line.
Fixing property typo.
Adding missing component text from react-native
andrewda
approved these changes
Oct 23, 2017
chinesedfan
reviewed
Oct 23, 2017
Member
chinesedfan
left a comment
chinesedfan
left a comment
There was a problem hiding this comment.
@alejandronanez Glad to see more and more contributors for styled components refactoring. But we didn't pay enough attentions for shorthands properties problem. Maybe we need mention this at #532.
| const CodeLineStyled = styled.Text` | ||
| font-family: ${styledFonts.fontCode} | ||
| font-size: ${normalize(11)} | ||
| padding: 3 10; |
Member
There was a problem hiding this comment.
@josenaranjo Have you ever tested about this kind of shorthands properties? As far as I know, it will cause a crash. [Link]
| const LineNumbers = styled.View` | ||
| width: 80; | ||
| padding-left: 10; | ||
| padding: 3; |
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting StyledSheet styles and migrating those to Styled-Components format.
Closes #515