Skip to content

feat(translation): add Esperanto translation#471

Merged
housseindjirdeh merged 9 commits intogitpoint:masterfrom
kodisto:master
Oct 14, 2017
Merged

feat(translation): add Esperanto translation#471
housseindjirdeh merged 9 commits intogitpoint:masterfrom
kodisto:master

Conversation

@kodisto
Copy link
Copy Markdown
Contributor

@kodisto kodisto commented Oct 13, 2017

For issue #439, translation of Esperanto

The esperanto flag has a star, but no emoji yet (we are working on this though!)
There's no direct for the concept of "forked", but forkis would logistically make the most since in the language. If there ever becomes a consensus on this, change it then. Otherwise I'm coining it now.
@andrewda andrewda changed the title Added Esperanto Translation feat(translation): add Esperanto translation Oct 13, 2017
Comment thread src/auth/screens/language-settings.js Outdated
},
{
code: 'eo',
emojiCode: ':star:',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be a flag, even if it's :waving_white_flag:.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @lex111 and i have discussed how we can possibly change this, but in the meantime :waving_white_flag: should do :)

@housseindjirdeh
Copy link
Copy Markdown
Member

Thank you @kodisto 🙏 Only thing is the flag emoticon, everything else looks solid 🎉

Copy link
Copy Markdown
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you 🙌

@housseindjirdeh housseindjirdeh merged commit 9b6f5b4 into gitpoint:master Oct 14, 2017
@chinesedfan
Copy link
Copy Markdown
Member

@housseindjirdeh This PR breaks ESLint. I will fix it in #478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants