wip: use GraphQL API to fetch issues and pull requests #455
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,36 @@ const METHOD = { | |
| POST: 'POST', | ||
| }; | ||
|
|
||
| export const v4 = { | ||
| root: 'https://api.github.com/graphql', | ||
| call: async parameters => { | ||
| const response = await fetch(v4.root, parameters); | ||
| const json = JSON.parse(response._bodyText); | ||
|
|
||
| if (response.status >= 200 && response.status < 300) { | ||
| return json.data; | ||
| } | ||
|
Member
There was a problem hiding this comment. Could we test for failed response.statuses instead before doing the JSON.parse() ?
Contributor
Author
There was a problem hiding this comment. The GraphQL API returns JSON on error as well as success. I do the JSON parsing ahead of this line so I can get the message out of the body as to why the query failed, to put in the
Member
There was a problem hiding this comment. Didn't know that, thanks for clarifying it, it's perfect that way then.
Contributor
Author
There was a problem hiding this comment. I might be able to do
Member
There was a problem hiding this comment. And it makes more sense along with Promise.reject() 👌 |
||
| const error = new Error(json.message); | ||
|
|
||
| error.response = response; | ||
| throw error; | ||
| }, | ||
|
Member
There was a problem hiding this comment. What about |
||
| parameters: (accessToken, body = {}) => { | ||
| return { | ||
| method: METHOD.POST, | ||
| headers: { | ||
| Authorization: `token ${accessToken}`, | ||
| }, | ||
|
Member
There was a problem hiding this comment. Haven't tried GraphQL on my side yet. Are this header enough? Shouldn't we be passing a User-Agent ? (GitPoint/Android-3.2 for example). I'd like to have it shared between GraphQL & Rest
Contributor
Author
There was a problem hiding this comment. This is all that's necessary to use the endpoint, though I could add a user-agent header. See the example at https://developer.github.com/v4/guides/forming-calls/#communicating-with-graphql. For trying the GraphQL API, I like https://developer.github.com/v4/explorer/, which lets you run queries as your GitHub user in the browser. |
||
| body: JSON.stringify(body), | ||
| }; | ||
| }, | ||
| post: async (accessToken, body) => { | ||
| const response = await v4.call(v4.parameters(accessToken, body)); | ||
|
|
||
| return response; | ||
| }, | ||
|
Member
There was a problem hiding this comment. is
Contributor
Author
There was a problem hiding this comment. Yep, all requests whether they're reading or writing, are POSTs; see https://developer.github.com/v4/guides/forming-calls/#communicating-with-graphql. I can merge these methods! |
||
| }; | ||
|
|
||
| export const v3 = { | ||
| root: 'https://api.github.com', | ||
| call: async (url, parameters) => { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉