fix(api): Run getRepositoryFile() through API, not raw.githubcontents#392
Merged
housseindjirdeh merged 1 commit intogitpoint:masterfrom Sep 30, 2017
machour:fix-code-file-display
Merged
fix(api): Run getRepositoryFile() through API, not raw.githubcontents#392housseindjirdeh merged 1 commit intogitpoint:masterfrom machour:fix-code-file-display
housseindjirdeh merged 1 commit intogitpoint:masterfrom
machour:fix-code-file-display
Conversation
lex111
approved these changes
Sep 30, 2017
andrewda
approved these changes
Sep 30, 2017
housseindjirdeh
approved these changes
Sep 30, 2017
Member
housseindjirdeh
left a comment
housseindjirdeh
left a comment
There was a problem hiding this comment.
Beautiful thank you <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the API change from #361, file source code fetching have not been working.
The problem was calling
.download_urlwhich points to a raw file onraw.githubcontents.cominstead of.urlwhich holds a proper API url.