chore(gitignore): drop stale config paths#2116
Open
obchain wants to merge 1 commit into
Open
Conversation
`.gitignore` listed two config paths that are actually tracked or don't exist: * `.gitleaks.toml` is the repo's dev allowlist config (added in 8863af4); ignoring it forces contributors to `git add -f` whenever it changes (gitleaks#1838). * `cmd/generate/config/gitleaks.toml` is not produced anywhere — the generator writes to `config/gitleaks.toml`. Drop both entries so `.gitleaks.toml` updates flow through `git add` normally and the dead path stops shadowing future use of the `cmd/generate/config/` directory. Closes gitleaks#1838
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
# configsblock in.gitignorelists two paths that are out of sync with the repo:.gitleaks.toml— the dev allowlist that was committed in 8863af4. While it's gitignored, any update to it requiresgit add -f, which is exactly what triggered.gitleaks.tomlin.gitignore#1838.cmd/generate/config/gitleaks.toml— no such file is produced anywhere in the build; the generator writes toconfig/gitleaks.toml. The entry looks like a leftover from a pre-refactor layout.Drop the block.
Verification
Test plan
git check-ignoreno longer flags.gitleaks.toml# configsare removed)Closes #1838