fix(rules): require sourcegraph context for bare 40-char hex tokens#2109
Open
obchain wants to merge 1 commit into
Open
fix(rules): require sourcegraph context for bare 40-char hex tokens#2109obchain wants to merge 1 commit into
obchain wants to merge 1 commit into
Conversation
The legacy bare 40-char hex shape collides with git commit SHAs, which caused false positives on commit/log content (gitleaks#1898). Split the rule: * sgp_-prefixed tokens stay unique enough to match on their own. * The bare 40-char hex shape now requires a "sourcegraph" identifier in proximity via GenerateSemiGenericRegex. Adds two git-SHA strings to the rule's FP list to lock the behavior in. Closes gitleaks#1898
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sourcegraph-access-tokenrule has a legacy bare-40-char-hex shape that collides with git commit SHAs, producing false positives on commit/log content (#1898).Split the regex via
MergeRegexps:sgp_-prefixed tokens stay unique enough to match standalone.sourcegraphidentifier in proximity viaGenerateSemiGenericRegex, mirroring how other ambiguous-shape rules handle this.Added two git-SHA strings to the rule's FP list so the behavior is locked in by
utils.Validate.Test plan
go generate ./...regeneratesconfig/gitleaks.tomlcleanly (Validate passes)go test ./...greensourcegraph_token = "<sha>"line, and 1sgp_local_<hex>token: bare SHAs ignored, sourcegraph-context hex flagged,sgp_token flaggedCloses #1898