-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Localize Security Best Practices article to Korean
#3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I reviewed the translation from the top then stopped at line 52 (before "## Avoid unwanted changes with protected branches" line) because I realized that the ko/security-best-practices-for-your-project.md and root security-best-practices-for-your-project.md have different text quite a lot.
I think it would be better to continue review after those original english (untranslated) files are updated to the latest version. Let me make another PR for that.
edit) here: #3582
Committing suggested edits for a more user-friendly tone Co-authored-by: Roeniss Moon <roeniss2@gmail.com>
|
@eazyhozy are you still working on this? If not, I want to take this issue. |
|
@roeniss can you wait for me finishing this PR? I'll update soon. Thanks for your following-up. |
|
no problem |
|
TAMUOnCHAIN-identity-layer |
|
# Conflicts: # _articles/ko/security-best-practices-for-your-project.md
|
@ahpook @roeniss @tomthorogood Thank you for reviewing and improving my PR. |
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
This PR adds a Korean translation of the Security Best Practices article.
Reference: https://opensource.guide/ko/security-best-practices-for-your-project/
Before (as-is)
After (to-be)