Skip to content

Conversation

@eazyhozy
Copy link

@eazyhozy eazyhozy commented Jan 7, 2026

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


This PR adds a Korean translation of the Security Best Practices article.

  • Localized the content, title, and description
  • Confirmed correct rendering on the landing page and article page after build

Reference: https://opensource.guide/ko/security-best-practices-for-your-project/

Before (as-is)

SCR-20260107-orsz SCR-20260107-oruw

After (to-be)

SCR-20260107-orne SCR-20260107-orpp

@eazyhozy eazyhozy requested a review from a team as a code owner January 7, 2026 07:57
Copy link
Contributor

@roeniss roeniss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I reviewed the translation from the top then stopped at line 52 (before "## Avoid unwanted changes with protected branches" line) because I realized that the ko/security-best-practices-for-your-project.md and root security-best-practices-for-your-project.md have different text quite a lot.

I think it would be better to continue review after those original english (untranslated) files are updated to the latest version. Let me make another PR for that.

edit) here: #3582

@ahpook
Copy link
Contributor

ahpook commented Jan 16, 2026

Thank you for this change @eazyhozy - once we get #3582 updated, could you please base your translation on that version of the doc? It was updated recently with a lot of good information.

Committing suggested edits for a more user-friendly tone

Co-authored-by: Roeniss Moon <roeniss2@gmail.com>
@roeniss
Copy link
Contributor

roeniss commented Jan 21, 2026

@eazyhozy are you still working on this? If not, I want to take this issue.

@eazyhozy
Copy link
Author

eazyhozy commented Jan 25, 2026

@roeniss can you wait for me finishing this PR? I'll update soon. Thanks for your following-up.

@roeniss
Copy link
Contributor

roeniss commented Jan 25, 2026

no problem

@jrsteve900
Copy link

TAMUOnCHAIN-identity-layer
Minimal onchain identity &referral attribution layer using SIWE (EIP-4361) . Phase1 focus on identity verification.

@jrsteve900
Copy link

TAMUOnCHAIN-identity-layer Minimal onchain identity &referral attribution layer using SIWE (EIP-4361) . Phase1 focus on identity verification.

# Conflicts:
#	_articles/ko/security-best-practices-for-your-project.md
@eazyhozy
Copy link
Author

eazyhozy commented Jan 25, 2026

@ahpook @roeniss @tomthorogood

Thank you for reviewing and improving my PR.
I've just merged the latest main(ac9ebe8)and re-reviewed the change by myself.
Please review this PR.

@eazyhozy eazyhozy requested a review from roeniss January 25, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants