Skip to content

[WIP] Update compiler to emit unlock-issue step in conclusion job#6290

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/update-compiler-unlock-issue-step
Closed

[WIP] Update compiler to emit unlock-issue step in conclusion job#6290
Copilot wants to merge 1 commit into
mainfrom
copilot/update-compiler-unlock-issue-step

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 12, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>[plan] Update compiler to emit unlock-issue step in conclusion job</issue_title>
<issue_description>## Objective

Modify the workflow compiler to emit a step that unlocks the issue in the conclusion job, ensuring it runs even on failure.

Context

Depends on #6202, #aw_ghi789jkl012, #aw_jkl012mno345 being completed. The conclusion job must unlock the issue regardless of agent success or failure.

Approach

  1. In pkg/workflow/compiler.go or the conclusion job builder, check if on.issue.lock-for-agent is true
  2. If enabled, emit a step in the conclusion job that runs unlock-issue.cjs script
  3. Ensure the step runs with if: always() condition so it executes even on failure
  4. Use the bundled script reference (similar to how other embedded scripts are used)
  5. Test by compiling a workflow with lock-for-agent: true and verify the generated YAML

Files to Modify

  • pkg/workflow/compiler.go or related conclusion job builder files
  • Test compilation with sample workflow

Acceptance Criteria

  • Compiler checks on.issue.lock-for-agent field from frontmatter
  • When true, conclusion job includes unlock-issue step
  • Step includes if: always() to run even on failure
  • Step executes in the conclusion job
  • Compiled workflow YAML includes the correct step structure
  • Manual test confirms issue unlocks after workflow completes or fails
    Related to Locking of issues #6201

AI generated by Plan Command for #6201

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[plan] Update compiler to emit unlock-issue step in conclusion job

3 participants