Skip to content

Add shared Playwright title smoke test - #57721

Merged
pelikhan merged 5 commits into
mainfrom
copilot/add-playwright-test-workflow
Sep 1, 2026
Merged

Add shared Playwright title smoke test#57721
pelikhan merged 5 commits into
mainfrom
copilot/add-playwright-test-workflow

Conversation

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Adds a reusable browser test that verifies agents can read JavaScript-rendered content with Playwright across engine and sandbox runtime combinations.

  • Shared test

    • Starts a loopback Node.js server from workflow steps.
    • Generates a cryptographically random expected title.
    • Injects the title client-side so it is absent from the HTML returned to curl.
    • Enables Playwright and prompts the agent to compare the rendered title exactly.
  • Coverage

    • Imports the test into Copilot, Codex, Claude, and Gemini smoke workflows.
    • Covers default and Cloud Hypervisor sandbox runtimes.
  • Generated workflows

    • Recompiles affected lock files.
    • Retains SHA-pinned action references.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.2 AIC · ⌖ 8.6 AIC · ⊞ 8.9K ·
Comment /souschef to run again


Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 19.5 AIC · ⌖ 8.76 AIC · ⊞ 8.9K ·
Comment /souschef to run again

Copilot AI and others added 3 commits September 1, 2026 15:19
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan September 1, 2026 15:32
@pelikhan
pelikhan marked this pull request as ready for review September 1, 2026 15:34
Copilot AI balanced review requested due to automatic review settings September 1, 2026 15:34
"version": "v6.1.0",
"sha": "55cc8345863c7cc4c66a329aec7e433d2d1c52a9"
},
"actions/checkout@v6.0.2": {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot fix any instance of v6 and upgrade to v7

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 54697af — updated the pre-agent-steps checkout in daily-multi-device-docs-tester.md from actions/checkout@v6.0.2 to actions/checkout@v7 and recompiled the lock file.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The host-bound loopback server is unreachable from Playwright running inside the AWF sandbox.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a reusable Playwright smoke test for JavaScript-rendered page titles across agent engines and sandbox runtimes.

Changes:

  • Adds a randomized loopback title-test server and validation prompt.
  • Imports the test into seven smoke workflows.
  • Regenerates workflow locks and synchronizes action pins.
File summaries
File Description
.github/workflows/shared/playwright-title-test.md Defines the shared test.
.github/workflows/smoke-copilot.md Enables the test for Copilot.
.github/workflows/smoke-copilot.lock.yml Regenerates Copilot workflow.
.github/workflows/smoke-copilot-small.md Enables Cloud Hypervisor coverage.
.github/workflows/smoke-copilot-small.lock.yml Regenerates small-model workflow.
.github/workflows/smoke-codex.md Enables the test for Codex.
.github/workflows/smoke-codex.lock.yml Regenerates Codex workflow.
.github/workflows/smoke-claude.md Enables the test for Claude.
.github/workflows/smoke-claude.lock.yml Regenerates Claude workflow.
.github/workflows/smoke-gemini.md Enables Gemini/Cloud Hypervisor coverage.
.github/workflows/smoke-agent-scoped-approved.md Adds scoped-agent coverage.
.github/workflows/smoke-agent-scoped-approved.lock.yml Regenerates scoped-agent workflow.
.github/workflows/smoke-test-tools.md Adds tool-container coverage.
.github/workflows/smoke-test-tools.lock.yml Regenerates tool smoke workflow.
.github/aw/actions-lock.json Adds the checkout action pin.
pkg/actionpins/data/action_pins.json Synchronizes action-pin data.
pkg/workflow/data/action_pins.json Synchronizes compiler pin data.
Review details
  • Files reviewed: 18/18 changed files
  • Comments generated: 1
  • Review effort level: Balanced

const fs = require("node:fs");
const http = require("node:http");

const host = "127.0.0.1";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 5024e3d — the server now binds to 0.0.0.0 instead of 127.0.0.1, host.docker.internal is added to the workflow's network.allowed list, and the agent is instructed to navigate to http://host.docker.internal:4173/ instead of 127.0.0.1:4173.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please address the latest review feedback and failed check on this PR, refresh the branch if needed, and run the pr-finisher skill before handing it back to maintainers.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 14.2 AIC · ⌖ 8.6 AIC · ⊞ 8.9K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please address the latest review feedback and failed check on this PR, refresh the branch if needed, and run the pr-finisher skill before handing it back to maintainers.

  • Failed check: Wi...

Addressed in 5024e3d: the Playwright title server now binds to 0.0.0.0, host.docker.internal is allowlisted in network.allowed, and the agent prompt navigates to http://host.docker.internal:4173/ so the AWF sandbox can reach the host-side server. Replied to both review threads.

The Windows Integration failure (run 33528127033) was a transient cache-restore abort (Failed to restore cache entry... The operation was aborted), not caused by this PR's changes — no code fix applies. make fmt/make lint/make test-unit/make recompile all pass locally on the current HEAD. Since my pushes don't retrigger CI, a maintainer will need to re-trigger checks (push/close-reopen/workflow_dispatch) to get a fresh green run.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Looks great! 🚀 Thanks for adding the Playwright title smoke test. This is a well-structured contribution that extends the test infrastructure with a reusable shared test for browser automation coverage.

The implementation is solid:

  • Clear test mechanics (loopback server with injected title, Playwright verification)
  • Integrated across all smoke workflows (Copilot, Claude, Codex, Gemini)
  • Proper coverage for both default and Cloud Hypervisor sandbox runtimes
  • Workflow lock files properly regenerated with SHA pinning retained

This PR is ready for review!

Generated by ✅ Contribution Check · copilot · auto · 46.5 AIC · ⌖ 7.92 AIC · ⊞ 9.3K ·

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please address the current review feedback on this PR, inspect the branch after the refresh request, and run the pr-finisher skill before handing it back to maintainers.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 19.5 AIC · ⌖ 8.76 AIC · ⊞ 8.9K ·
Comment /souschef to run again

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please address the current review feedback on this PR, inspect the branch after the refresh request, and run the pr-finisher skill before handing it back to maintainers.

  • Latest reviewer ...

No new code changes needed — the referenced copilot-pull-request-reviewer "changes recommended" review is the same one from commit 00b592e that was already fixed in 5024e3d (server bound to 0.0.0.0, host.docker.internal allowlisted, agent navigates via host.docker.internal:4173). Both review threads have replies confirming the fix.

The firewall warning (github.com blocked) comes from the Sous Chef workflow's own run (33537945047), not from this PR's changes — this PR doesn't touch that workflow's network config, so it isn't actionable here.

Current HEAD (5024e3d) already reflects all fixes; make fmt/make lint/make test-unit/make recompile pass locally. Remaining blocker: CI must be re-triggered by a maintainer since my pushes don't retrigger workflow runs.

@pelikhan
pelikhan merged commit 078cb57 into main Sep 1, 2026
34 checks passed
@pelikhan
pelikhan deleted the copilot/add-playwright-test-workflow branch September 1, 2026 18:10
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.88.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants