Add shared Playwright title smoke test - #57721
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| "version": "v6.1.0", | ||
| "sha": "55cc8345863c7cc4c66a329aec7e433d2d1c52a9" | ||
| }, | ||
| "actions/checkout@v6.0.2": { |
There was a problem hiding this comment.
@copilot fix any instance of v6 and upgrade to v7
There was a problem hiding this comment.
Fixed in 54697af — updated the pre-agent-steps checkout in daily-multi-device-docs-tester.md from actions/checkout@v6.0.2 to actions/checkout@v7 and recompiled the lock file.
There was a problem hiding this comment.
🟡 Changes recommended
The host-bound loopback server is unreachable from Playwright running inside the AWF sandbox.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a reusable Playwright smoke test for JavaScript-rendered page titles across agent engines and sandbox runtimes.
Changes:
- Adds a randomized loopback title-test server and validation prompt.
- Imports the test into seven smoke workflows.
- Regenerates workflow locks and synchronizes action pins.
File summaries
| File | Description |
|---|---|
.github/workflows/shared/playwright-title-test.md |
Defines the shared test. |
.github/workflows/smoke-copilot.md |
Enables the test for Copilot. |
.github/workflows/smoke-copilot.lock.yml |
Regenerates Copilot workflow. |
.github/workflows/smoke-copilot-small.md |
Enables Cloud Hypervisor coverage. |
.github/workflows/smoke-copilot-small.lock.yml |
Regenerates small-model workflow. |
.github/workflows/smoke-codex.md |
Enables the test for Codex. |
.github/workflows/smoke-codex.lock.yml |
Regenerates Codex workflow. |
.github/workflows/smoke-claude.md |
Enables the test for Claude. |
.github/workflows/smoke-claude.lock.yml |
Regenerates Claude workflow. |
.github/workflows/smoke-gemini.md |
Enables Gemini/Cloud Hypervisor coverage. |
.github/workflows/smoke-agent-scoped-approved.md |
Adds scoped-agent coverage. |
.github/workflows/smoke-agent-scoped-approved.lock.yml |
Regenerates scoped-agent workflow. |
.github/workflows/smoke-test-tools.md |
Adds tool-container coverage. |
.github/workflows/smoke-test-tools.lock.yml |
Regenerates tool smoke workflow. |
.github/aw/actions-lock.json |
Adds the checkout action pin. |
pkg/actionpins/data/action_pins.json |
Synchronizes action-pin data. |
pkg/workflow/data/action_pins.json |
Synchronizes compiler pin data. |
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 1
- Review effort level: Balanced
| const fs = require("node:fs"); | ||
| const http = require("node:http"); | ||
|
|
||
| const host = "127.0.0.1"; |
There was a problem hiding this comment.
Fixed in 5024e3d — the server now binds to 0.0.0.0 instead of 127.0.0.1, host.docker.internal is added to the workflow's network.allowed list, and the agent is instructed to navigate to http://host.docker.internal:4173/ instead of 127.0.0.1:4173.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot Please address the latest review feedback and failed check on this PR, refresh the branch if needed, and run the
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Addressed in 5024e3d: the Playwright title server now binds to The Windows Integration failure (run 33528127033) was a transient cache-restore abort ( |
|
Looks great! 🚀 Thanks for adding the Playwright title smoke test. This is a well-structured contribution that extends the test infrastructure with a reusable shared test for browser automation coverage. The implementation is solid:
This PR is ready for review!
|
|
@copilot Please address the current review feedback on this PR, inspect the branch after the refresh request, and run the
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
No new code changes needed — the referenced The firewall warning ( Current HEAD ( |
|
🎉 This pull request is included in a new release. Release: |
Adds a reusable browser test that verifies agents can read JavaScript-rendered content with Playwright across engine and sandbox runtime combinations.
Shared test
curl.Coverage
Generated workflows
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
github.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.