Skip to content

Add regression test confirming top-level roles: is rejected by schema validation #56981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Aug 29, 2026
Merged

Add regression test confirming top-level roles: is rejected by schema validation #56981

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f162f6e
Initial plan
Copilot Aug 29, 2026
ad3f6e7
Add regression test for top-level roles rejection
Copilot Aug 29, 2026
445e274
Tighten regression test assertion for top-level roles rejection
Copilot Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/parser/schema_location_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,16 @@ func TestValidateMainWorkflowFrontmatterWithSchemaAndLocation_AdditionalProperti
wantErr: true,
errContains: "requird",
},
{
name: "top-level roles field is rejected pointing to on.roles",
frontmatter: map[string]any{
"on": "push",
"roles": []string{"admin", "maintainer", "write"},
},
filePath: "/test/workflow.md",
wantErr: true,
errContains: "'roles' belongs under 'on'",
},
{
name: "dispatch-repository key is accepted by schema",
frontmatter: map[string]any{
Expand Down
Loading