Skip to content

Fix stale Daily Firewall Report scope in metrics glossary - #56979

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-daily-firewall-report-glossary
Aug 29, 2026
Merged

Fix stale Daily Firewall Report scope in metrics glossary#56979
pelikhan merged 2 commits into
mainfrom
copilot/fix-daily-firewall-report-glossary

Conversation

Copilot AI commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

The metrics glossary was still describing the Daily Firewall Report as a 7-day report, while the workflow actually collects and analyzes only the last 24 hours. This mismatch can create drift in cross-report metric validation because the glossary is treated as the canonical scope reference.

  • Summary

    • The glossary entry for workflow_runs_analyzed was stale and inconsistent with the actual firewall report configuration.
    • The workflow imports the shared 24-hour log fetch and explicitly documents the reporting window as the last 24 hours.
  • Changes

    • Updated scratchpad/metrics-glossary.md to reflect the correct scope for the Daily Firewall Report:
      • from: Daily Firewall Report (last 7 days)
      • to: Daily Firewall Report (last 24 hours)
  • Impact

    • Aligns the canonical cross-report metric glossary with the real behavior of .github/workflows/daily-firewall-report.md.
    • Prevents downstream report validation or interpretation from treating the firewall report as a 7-day window when it is in fact 24-hour scoped.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Daily Firewall Report documentation for accuracy Fix stale Daily Firewall Report scope in metrics glossary Aug 29, 2026
Copilot AI requested a review from pelikhan August 29, 2026 21:50
@pelikhan
pelikhan marked this pull request as ready for review August 29, 2026 22:08
Copilot AI balanced review requested due to automatic review settings August 29, 2026 22:08
@pelikhan
pelikhan merged commit 3cebee7 into main Aug 29, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/fix-daily-firewall-report-glossary branch August 29, 2026 22:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation now matches the workflow configuration and resolves the linked issue.

Pull request overview

Corrects the metrics glossary to match the Daily Firewall Report’s actual 24-hour scope.

Changes:

  • Replaces the stale 7-day scope with 24 hours.
File summaries
File Description
scratchpad/metrics-glossary.md Corrects the documented reporting window.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] metrics-glossary.md says Daily Firewall Report covers last 7 days, but workflow actually uses 24h window

3 participants