Fix stale Daily Firewall Report scope in metrics glossary - #56979
Merged
Conversation
2 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Daily Firewall Report documentation for accuracy
Fix stale Daily Firewall Report scope in metrics glossary
Aug 29, 2026
pelikhan
marked this pull request as ready for review
August 29, 2026 22:08
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation now matches the workflow configuration and resolves the linked issue.
Pull request overview
Corrects the metrics glossary to match the Daily Firewall Report’s actual 24-hour scope.
Changes:
- Replaces the stale 7-day scope with 24 hours.
File summaries
| File | Description |
|---|---|
scratchpad/metrics-glossary.md |
Corrects the documented reporting window. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics glossary was still describing the Daily Firewall Report as a 7-day report, while the workflow actually collects and analyzes only the last 24 hours. This mismatch can create drift in cross-report metric validation because the glossary is treated as the canonical scope reference.
Summary
workflow_runs_analyzedwas stale and inconsistent with the actual firewall report configuration.Changes
scratchpad/metrics-glossary.mdto reflect the correct scope for the Daily Firewall Report:Daily Firewall Report (last 7 days)Daily Firewall Report (last 24 hours)Impact
.github/workflows/daily-firewall-report.md.