Define deterministic dashboard custom-link semantics - #56056
Merged
pelikhan merged 2 commits intoAug 26, 2026
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Define deterministic custom-link semantics in dashboard
Define deterministic dashboard custom-link semantics
Aug 26, 2026
pelikhan
marked this pull request as ready for review
August 26, 2026 14:15
pelikhan
deleted the
copilot/dashboard-language-spec-define-custom-link-semanti
branch
August 26, 2026 14:16
Contributor
There was a problem hiding this comment.
Pull request overview
Defines deterministic link fields and custom href behavior in the dashboard language specification.
Changes:
- Adds relation-specific source link fields.
- Defines rendering, validation, and accessibility semantics.
- Adds compliance fixture requirements and
DLS-E009coverage.
Show a summary per file
| File | Description |
|---|---|
docs/src/content/docs/specs/dashboard-language-specification.md |
Updates normative link, custom-view, validation, and compliance rules. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
| - **DLS-VIEW-011:** A custom view **MUST NOT** contain scripts, joins, formulas, expressions, templates, plugins, or undeclared transforms. | ||
| - **DLS-VIEW-012:** A custom view **MUST** apply defaults, filtering, aggregation, ordering, and limiting in the order defined by Sections 6, 7, and 11.2. | ||
| - **DLS-VIEW-013:** A custom view **MUST** expose its source provenance, freshness, completeness, effective scope, effective time range, and effective filters. | ||
| - **DLS-VIEW-014:** A presenter rendering `href` **MUST** use the referenced link object's `href` as the navigation target and **MUST** expose the link object's `label` as the accessible link label. If the referenced link field is absent for a datum, the datum **MUST** remain valid and **MUST** render without a link. |
| ### 9.1 Link Model | ||
|
|
||
| A link has `relation`, `href`, and `label`. Allowed relations are `organization`, `repository`, `workflow`, `run`, `issue`, `pull-request`, `evidence`, and `external`. | ||
| A link has `relation`, `href`, and `label`. Allowed relations are `organization`, `repository`, `workflow`, `run`, `issue`, `pull-request`, `evidence`, and `external`. When a relation-specific link field from Section 5.1 is present on a source row, it contains exactly one link object whose `relation` matches the field name. |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard language spec left custom
hrefrendering ambiguous: source rows mixed singularlinkfields with multi-link semantics, and validators had no closed rule for invalid link references.Source link model
linkfields onfindingsandoutcomeswith relation-specific fields:issue-link,pull-request-link,run-link, andexternal-link.Custom
hrefsemanticshref.fieldto reference a link-typed source field.hrefas the target andlabelas the accessible link label.hrefreferences toDLS-E009.Compliance coverage