Remove unreferenced $defs entries from main workflow schema

[Copilot]

The daily schema consistency audit flagged an unreferenced $defs entry in pkg/parser/schemas/main_workflow_schema.json.

Root cause

max_effective_tokens_limit and positive_effective_tokens_limit were leftover definitions from before the "Effective Tokens" cost metric was renamed to "AI Credits" (see ADR-36496). The max-effective-tokens frontmatter field was renamed to max-ai-credits, which was migrated to reference the newer max_ai_credits_limit / positive_ai_credits_limit defs — but the old defs were never cleaned up, leaving them dangling with zero references in the schema.

Changes

• Removed the orphaned max_effective_tokens_limit and positive_effective_tokens_limit $defs entries from main_workflow_schema.json
• No property or validation behavior changes — these defs were not referenced by any schema property

-    "positive_effective_tokens_limit": {
-      "oneOf": [
-        { "type": "integer", "minimum": 1 },
-        { "$ref": "#/$defs/positive_integer_with_km_suffix_or_expression" }
-      ]
-    },
     "positive_ai_credits_limit": {
       ...
     },
-    "max_effective_tokens_limit": {
-      "description": "Maximum effective-token (ET) budget for AWF API proxy enforcement...",
-      "oneOf": [
-        { "$ref": "#/$defs/positive_effective_tokens_limit" },
-        { "type": "integer", "maximum": -1 }
-      ]
-    },
     "max_daily_ai_credits_limit": {
       ...
     },

• Fixes [schema-audit] Daily Schema Consistency Report — 32812348684 #55656

[Copilot]

Pull request overview

Removes obsolete Effective Tokens schema definitions after migration to AI Credits.

Changes:

• Removes both legacy, unused $defs entries.
• Preserves existing schema validation behavior.

Show a summary per file

File	Description
pkg/parser/schemas/main_workflow_schema.json	Removes unreferenced Effective Tokens definitions.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.8