Fix update-pull-request generated footer spacing - #55372
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Fix update-pull-request footer spacing
Fix update-pull-request generated footer spacing
Aug 24, 2026
Copilot created this pull request from a session on behalf of
pelikhan
August 24, 2026 11:53
View session
pelikhan
marked this pull request as ready for review
August 24, 2026 11:56
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures generated attribution footers remain separated from updated PR body content.
Changes:
- Adds a shared blank-line-prefixed footer section across all update modes.
- Adds regression tests for
replace,append,prepend, andreplace-island.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/update_pr_description_helpers.cjs |
Adds consistent footer spacing during body assembly. |
actions/setup/js/update_pr_description_helpers.test.cjs |
Verifies footer separation for every update mode. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_pull_requestcould append the generated footer directly after new body content, causing malformed PR descriptions such asrun: ...> Generated by .... This adds an explicit blank-line boundary before the generated footer across PR body update modes.Body assembly
\n\n.replace,append,prepend, andreplace-island.Regression coverage
run: ...body shape that exposed the formatting issue.Example output shape: