Skip to content

Bump default gh-aw-firewall (AWF) version to v0.28.5 - #54894

Merged
pelikhan merged 5 commits into
mainfrom
copilot/bump-awf-firewall-versions
Aug 22, 2026
Merged

Bump default gh-aw-firewall (AWF) version to v0.28.5#54894
pelikhan merged 5 commits into
mainfrom
copilot/bump-awf-firewall-versions

Conversation

Copilot AI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Pins the gh-aw-firewall (AWF) default version to the latest release, v0.28.5.

Version constant

  • pkg/constants/version_constants.go: DefaultFirewallVersion bumped from v0.28.4v0.28.5.
  • Compared v0.28.5's CLI options against v0.28.4: no new, changed, deprecated, or removed flags — the release is internal fixes only (Cloud Hypervisor readiness recovery, filesystem allowWrite boundary enforcement, CLI artifact redirect routing, tracking-issue link fixes). No AWF*MinVersion constants required changes.

Generated artifacts

  • Recompiled all workflow .lock.yml files to reference the new default.
  • Refreshed AWF container image digest pins for squid, agent, api-proxy, and cli-proxy at v0.28.5 in .github/aw/actions-lock.json and pkg/actionpins/data/action_pins.json / pkg/workflow/data/action_pins.json.

Changeset

  • Added a patch changeset documenting the version bump.

Copilot AI linked an issue Aug 22, 2026 that may be closed by this pull request
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot AI changed the title [WIP] Update AWF/firewall versions to v0.28.5 Bump default gh-aw-firewall (AWF) version to v0.28.5 Aug 22, 2026
Copilot AI requested a review from lpcox August 22, 2026 19:08
@lpcox
lpcox marked this pull request as ready for review August 22, 2026 19:12
Copilot AI balanced review requested due to automatic review settings August 22, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the default AWF release to v0.28.5 and regenerates dependent pins and workflows. The update misses AWF’s new filesystem schema integration and unintentionally removes a workflow-router entry.

Changes:

  • Updates the default AWF version and container digests.
  • Recompiles workflow lock files for v0.28.5.
  • Adds a patch changeset but removes skills/plugin routing guidance.
Show a summary per file
File Description
pkg/constants/version_constants.go Bumps the default AWF version.
pkg/workflow/data/action_pins.json Adds v0.28.5 image pins.
pkg/actionpins/data/action_pins.json Adds v0.28.5 image pins.
.github/aw/actions-lock.json Adds v0.28.5 image pins.
.github/workflows/smoke-ci.lock.yml Regenerates Smoke CI with v0.28.5.
.github/workflows/notion-issue-summary.lock.yml Regenerates Notion workflow.
.github/workflows/hippo-embed.lock.yml Regenerates Hippo workflow.
.github/workflows/firewall.lock.yml Regenerates firewall test workflow.
.github/workflows/example-permissions-warning.lock.yml Regenerates permissions example.
.github/workflows/daily-arxiv-researcher.lock.yml Regenerates researcher workflow.
.github/workflows/codex-github-remote-mcp-test.lock.yml Regenerates Codex test workflow.
.github/skills/agentic-workflows/SKILL.md Removes a skills/plugin routing entry.
.changeset/patch-bump-firewall-v0-28-5.md Documents the patch release change.

Review details

  • Files reviewed: 21/295 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment on lines +106 to +108

When the task involves OTEL, OTLP, traces, observability backends, or telemetry-driven analysis, also read and follow `skills/otel-queries/SKILL.md` after loading the matching workflow prompt or skill.

@@ -64,7 +64,7 @@ const DefaultGitHubMCPServerVersion Version = "v1.10.0"
//
// The first recompile regenerates all lock files using the new version; the second recompile
// refreshes the container SHA pins that were resolved during the first pass.
const DefaultFirewallVersion Version = "v0.28.4"
const DefaultFirewallVersion Version = "v0.28.5"
@lpcox

lpcox commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

@copilot run the pr-finisher skill

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #54894 does not have the implementation label and has 0 new lines of code in business logic directories (threshold: 100). The PR modifies 295 files but none in src/, lib/, pkg/, internal/, app/, core/, domain/, services/, or api/.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Ponytail Reviewer completed successfully!

Lean already. Ship. This PR is a pure version bump (DefaultFirewallVersion v0.28.4->v0.28.5) plus generated artifacts (recompiled .lock.yml files, actions-lock.json, action_pins.json) and a changeset entry. No hand-written logic in the diff to assess for over-engineering.

Generated by Ponytail Reviewer for #54894

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. This PR bumps the gh-aw-firewall (AWF) version to v0.28.5, updating generated workflow lock files (.lock.yml), a changeset, and documentation. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

No new review comments were posted because the actionable issues in the changed lines were already covered by existing PR review comments, and I found no additional non-duplicate changed-line defects.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /codebase-design and /grill-with-docs — requesting changes on two issues already surfaced by inline review comments.

📋 Key Themes

Issues to Address

  1. Unrelated deletion in SKILL.md — The skills/plugins dispatcher routing line was removed with no explanation. This silently breaks the skill-routing path for skills:/plugins: frontmatter requests. Restore it or document why it should go.

  2. Schema not updated for filesystem.allowWrite — v0.28.5 adds a top-level filesystem.allowWrite config field per upstream PR #7634. pkg/workflow/schemas/awf-config.schema.json does not yet accept this field, so workflows using it will fail validation after the bump. The schema update (or AWFMinVersion guard) should accompany this version bump.

Positive Highlights

  • ✅ All 295 lock files are consistently recompiled to the new digest pins
  • ✅ Container image digests are SHA-pinned — good supply-chain hygiene
  • ✅ Changeset entry is correctly scoped as patch
  • ✅ PR description clearly documents the diff against v0.28.4 CLI flags

Please address the two existing inline comments before merging.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 30.5 AIC · ⌖ 13.6 AIC · ⊞ 7.6K
Comment /matt to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Bump default AWF version to v0.28.5

This is a version bump PR with ~295 regenerated lock files. The core change (DefaultFirewallVersion constant + recompiled artifacts) looks mechanically correct.

The two existing inline comments already flag the substantive concerns:

  1. .github/skills/agentic-workflows/SKILL.md — an unrelated skills routing entry deletion that should be restored.
  2. pkg/constants/version_constants.go — schema compatibility gap for the new filesystem.allowWrite config field introduced in v0.28.5.

No additional issues found beyond what is already flagged.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 27 AIC · ⌖ 9 AIC · ⊞ 6.2K

@github-actions

Copy link
Copy Markdown
Contributor

Comment Memory

reviewed_at: 2026-08-22T00:00:00Z
review_event: COMMENT
top_themes:
  - existing blocking concerns already raised by prior reviewer
  - no additional changed-line issues found in regenerated lockfiles/files reviewed
files_reviewed:
  - .changeset/patch-bump-firewall-v0-28-5.md
  - .github/aw/actions-lock.json
  - .github/skills/agentic-workflows/SKILL.md
  - .github/workflows/ab-testing-advisor.lock.yml
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 18.1 AIC · ⌖ 6.81 AIC · ⊞ 7K ·
Comment /review to run again

@github-actions github-actions Bot mentioned this pull request Aug 22, 2026
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot this PR still needs forward progress.

Run: https://github.com/github/gh-aw/actions/runs/32593943861

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.8 AIC · ⌖ 8.27 AIC · ⊞ 7.1K ·
Comment /souschef to run again

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@copilot run the pr-finisher skill

Ran the pr-finisher workflow and pushed edb8c19.

Copilot AI and others added 2 commits August 22, 2026 19:48
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@copilot this PR still needs forward progress.

Restored the skills/plugins dispatcher route in f68ca78. The requested AWF filesystem schema/model/mapping integration is included in edb8c19. I reviewed the Unit tests (N-R) log and reproduced its exact full-shard command locally with CI=true; it passed without the reported closed-file coverage error.

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump AWF/firewall versions to v0.28.5

5 participants