Bump default gh-aw-firewall (AWF) version to v0.28.5 - #54894
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Bumps the default AWF release to v0.28.5 and regenerates dependent pins and workflows. The update misses AWF’s new filesystem schema integration and unintentionally removes a workflow-router entry.
Changes:
- Updates the default AWF version and container digests.
- Recompiles workflow lock files for v0.28.5.
- Adds a patch changeset but removes skills/plugin routing guidance.
Show a summary per file
| File | Description |
|---|---|
pkg/constants/version_constants.go |
Bumps the default AWF version. |
pkg/workflow/data/action_pins.json |
Adds v0.28.5 image pins. |
pkg/actionpins/data/action_pins.json |
Adds v0.28.5 image pins. |
.github/aw/actions-lock.json |
Adds v0.28.5 image pins. |
.github/workflows/smoke-ci.lock.yml |
Regenerates Smoke CI with v0.28.5. |
.github/workflows/notion-issue-summary.lock.yml |
Regenerates Notion workflow. |
.github/workflows/hippo-embed.lock.yml |
Regenerates Hippo workflow. |
.github/workflows/firewall.lock.yml |
Regenerates firewall test workflow. |
.github/workflows/example-permissions-warning.lock.yml |
Regenerates permissions example. |
.github/workflows/daily-arxiv-researcher.lock.yml |
Regenerates researcher workflow. |
.github/workflows/codex-github-remote-mcp-test.lock.yml |
Regenerates Codex test workflow. |
.github/skills/agentic-workflows/SKILL.md |
Removes a skills/plugin routing entry. |
.changeset/patch-bump-firewall-v0-28-5.md |
Documents the patch release change. |
Review details
- Files reviewed: 21/295 changed files
- Comments generated: 2
- Review effort level: Balanced
|
|
||
| When the task involves OTEL, OTLP, traces, observability backends, or telemetry-driven analysis, also read and follow `skills/otel-queries/SKILL.md` after loading the matching workflow prompt or skill. | ||
|
|
| @@ -64,7 +64,7 @@ const DefaultGitHubMCPServerVersion Version = "v1.10.0" | |||
| // | |||
| // The first recompile regenerates all lock files using the new version; the second recompile | |||
| // refreshes the container SHA pins that were resolved during the first pass. | |||
| const DefaultFirewallVersion Version = "v0.28.4" | |||
| const DefaultFirewallVersion Version = "v0.28.5" | |||
|
@copilot run the pr-finisher skill |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #54894 does not have the implementation label and has 0 new lines of code in business logic directories (threshold: 100). The PR modifies 295 files but none in src/, lib/, pkg/, internal/, app/, core/, domain/, services/, or api/.
|
|
✅ Ponytail Reviewer completed successfully! Lean already. Ship. This PR is a pure version bump (DefaultFirewallVersion v0.28.4->v0.28.5) plus generated artifacts (recompiled .lock.yml files, actions-lock.json, action_pins.json) and a changeset entry. No hand-written logic in the diff to assess for over-engineering.
|
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. This PR bumps the gh-aw-firewall (AWF) version to v0.28.5, updating generated workflow lock files (.lock.yml), a changeset, and documentation. Test Quality Sentinel skipped.
|
|
✅ PR Code Quality Reviewer completed the code quality review. No new review comments were posted because the actionable issues in the changed lines were already covered by existing PR review comments, and I found no additional non-duplicate changed-line defects.
|
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design and /grill-with-docs — requesting changes on two issues already surfaced by inline review comments.
📋 Key Themes
Issues to Address
-
Unrelated deletion in
SKILL.md— The skills/plugins dispatcher routing line was removed with no explanation. This silently breaks the skill-routing path forskills:/plugins:frontmatter requests. Restore it or document why it should go. -
Schema not updated for
filesystem.allowWrite— v0.28.5 adds a top-levelfilesystem.allowWriteconfig field per upstream PR #7634.pkg/workflow/schemas/awf-config.schema.jsondoes not yet accept this field, so workflows using it will fail validation after the bump. The schema update (orAWFMinVersionguard) should accompany this version bump.
Positive Highlights
- ✅ All 295 lock files are consistently recompiled to the new digest pins
- ✅ Container image digests are SHA-pinned — good supply-chain hygiene
- ✅ Changeset entry is correctly scoped as
patch - ✅ PR description clearly documents the diff against v0.28.4 CLI flags
Please address the two existing inline comments before merging.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 30.5 AIC · ⌖ 13.6 AIC · ⊞ 7.6K
Comment /matt to run again
There was a problem hiding this comment.
Review: Bump default AWF version to v0.28.5
This is a version bump PR with ~295 regenerated lock files. The core change (DefaultFirewallVersion constant + recompiled artifacts) looks mechanically correct.
The two existing inline comments already flag the substantive concerns:
.github/skills/agentic-workflows/SKILL.md— an unrelated skills routing entry deletion that should be restored.pkg/constants/version_constants.go— schema compatibility gap for the newfilesystem.allowWriteconfig field introduced in v0.28.5.
No additional issues found beyond what is already flagged.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 27 AIC · ⌖ 9 AIC · ⊞ 6.2K
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
|
@copilot this PR still needs forward progress.
Run: https://github.com/github/gh-aw/actions/runs/32593943861
|
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Ran the pr-finisher workflow and pushed |
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Restored the skills/plugins dispatcher route in |
|
🎉 This pull request is included in a new release. Release: |
Pins the
gh-aw-firewall(AWF) default version to the latest release,v0.28.5.Version constant
pkg/constants/version_constants.go:DefaultFirewallVersionbumped fromv0.28.4→v0.28.5.allowWriteboundary enforcement, CLI artifact redirect routing, tracking-issue link fixes). NoAWF*MinVersionconstants required changes.Generated artifacts
.lock.ymlfiles to reference the new default.squid,agent,api-proxy, andcli-proxyatv0.28.5in.github/aw/actions-lock.jsonandpkg/actionpins/data/action_pins.json/pkg/workflow/data/action_pins.json.Changeset